Add fragment.encrypted unit tests for manifest signalled DRM (PlayReady and Widevine) #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsjamie
commented
May 13, 2020
itsjamie
changed the title
itsjamie
changed the title
robwalch
approved these changes
May 13, 2020
itsjamie
commented
May 13, 2020
itsjamie
commented
May 13, 2020
robwalch
approved these changes
May 14, 2020
itsjamie
commented
May 14, 2020
| expect(frag.encrypted).to.equal(true); | ||
| }); | ||
|
|
||
| it('returns true for widevine v2 manifest signalled encryption', function () { |
There was a problem hiding this comment.
while these tests return true, currently, via integration they won't ever be set on the fragment as these keys are currently set as "unknown" keyformats, since we don't handle them as a client yet.
When fragments are signalled from the manifest they are encrypted we need to be able to detect this fact. Currently we use the boolean "encrypted" on Fragment to support this. So I've added some tests that cover the current behaviour for AES-128 encryption, and some skipped tests that cover the future usecase. Additionally, this change includes a tiny change to the LevelKey class. It now has a private constructor, and two static methods to create itself. `fromURL` and `fromURI`, one supports the current usecase for absolute or relative URLs, and the other is for supporting the future use-case of URI keys.
We want to download the key not when a fragment reports that it is encrypted. But specifically when it is an identity key, that hasn't been loaded already.
itsjamie
force-pushed
the
chore/add-encrypted-unit-tests
branch
from
e108026 to
a244799
Compare
itsjamie
commented
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
When fragments are signalled from the manifest they are encrypted we
need to be able to detect this fact. Currently we use the boolean
"encrypted" on Fragment to support this. So I've added some tests that
cover the current behaviour for AES-128 encryption, and some
skippedtests that cover the future usecase.
Additionally, this change includes a tiny change to the LevelKey class.
It now has a private constructor, and two static methods to create
itself.
fromURLandfromURI, one supports the current usecase forabsolute or relative URLs, and the other is for supporting the future
use-case of URI keys.
As the meaning of the
encryptedgetter on Fragment has been changedto mean that a fragment has a
EXT-X-KEYassociated with it, locations where it was usedcurrently for determining if a key needed to be loaded have been changed to
directly reference the appropriate properties.
Why is this Pull Request needed?
We need to know when fragments are encrypted beyond the current
support for AES-128 segments if we are going to notify users when
encrypted content is being encountered from a manifest only
perspective.
Are there any points in the code the reviewer needs to double check?
The unit tests make sense.